Resolve FileDownloader.get_os_version
exception for missing lsb_release
#2911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes IDAES/idaes-pse#1221
Summary/Motivation:
FileDownloader.get_os_version()
will generateFileNotFoundError
exceptions on Linux platforms that are missinglsb_release
in thePATH
. This resolves that exception by first checking for the existence of the executable usingshutil.which()
(the approach recommended for locating executables in thesubprocess.Popen
documentation)Changes proposed in this PR:
shutil.which
to locate / check for the existence oflsb_release
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: