Resolve error categorizing some Var discrete domains as "integer" #2954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
Variables with domains defined with a domain with step 1, but not starting at an integer value were being categorized as "integer" domains. This updates
is_integer()
to correctly reportFalse
for discrete domains that are not rooted (start or stop) at integer values. This adds a test to exercise / verify the expected behavior.Changes proposed in this PR:
is_integer()
should only beTrue
if the range starts/ends at an integerLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: