Fix differentiation of Expressions
containing native_numeric_types
#3017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2986
Summary/Motivation:
Recently, Pyomo changed the Expression object API so that
.expr
would always return a class derived fromNumericValue
, but not necessarily the same object each time it was called. As a result, walkers that key off the expression child need to use.arg(0)
and not.expr
. This PR resolves that bug in the Pyomoreverse_ad
walker.Changes proposed in this PR:
.arg(0)
and not.expr
when accessing the child of anExpression
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: