Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve build infrastructure errors (with mpi4py, gams, networkx) #3018

Merged
merged 11 commits into from
Oct 20, 2023

Conversation

jsiirola
Copy link
Member

@jsiirola jsiirola commented Oct 18, 2023

Fixes # .

Summary/Motivation:

This resolves numerous several errors relating to the build/test infrastructure that all arose during the migration to supporting Python 3.12:

  • openmpi installation on conda started triggering installation errors. In the end, this switches the tests to not specifying openmpi (and instead defaulting to using mpich). In the course of working on this, it also identified bugs in the logic for skipping MPI tests.
  • networkx had a broken build pushed to pypi that enabled installation of 3.2 on Python 3.8 (3.2 requires Python >= 3.9). This refines our optional requirements to explicitly exclude networkx 3.2 on Python < 3.9. This highlighted a bug in how we were doing version comparison in setup.py
  • This tracks a move in a GAMS import

Changes proposed in this PR:

  • switch MPI tests to not use openmpi
  • fix logic for skipping MPI tests
  • restrict the networkx version for python<3.9
  • update GAMS import of GamsExceptionExecution

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4267cbd) 87.92% compared to head (0593891) 87.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3018      +/-   ##
==========================================
- Coverage   87.92%   87.84%   -0.09%     
==========================================
  Files         769      769              
  Lines       89538    89541       +3     
==========================================
- Hits        78727    78657      -70     
- Misses      10811    10884      +73     
Flag Coverage Δ
linux 85.17% <0.00%> (-0.01%) ⬇️
osx 74.97% <0.00%> (-0.01%) ⬇️
other 85.35% <0.00%> (-0.01%) ⬇️
win 82.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pyomo/solvers/plugins/solvers/GAMS.py 60.66% <50.00%> (-6.91%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsiirola jsiirola changed the title Resolve Conda setup error (with mpi4py/openmpi) Resolve build infrastructure errors (with mpi4py, gams, networkx) Oct 20, 2023
@jsiirola jsiirola merged commit 40c3dae into Pyomo:main Oct 20, 2023
29 of 30 checks passed
@jsiirola jsiirola deleted the conda-setup-error branch October 20, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants