-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve build infrastructure errors (with mpi4py, gams, networkx) #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3018 +/- ##
==========================================
- Coverage 87.92% 87.84% -0.09%
==========================================
Files 769 769
Lines 89538 89541 +3
==========================================
- Hits 78727 78657 -70
- Misses 10811 10884 +73
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
jsiirola
changed the title
Resolve Conda setup error (with mpi4py/openmpi)
Resolve build infrastructure errors (with mpi4py, gams, networkx)
Oct 20, 2023
emma58
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This resolves numerous several errors relating to the build/test infrastructure that all arose during the migration to supporting Python 3.12:
openmpi
installation on conda started triggering installation errors. In the end, this switches the tests to not specifying openmpi (and instead defaulting to using mpich). In the course of working on this, it also identified bugs in the logic for skipping MPI tests.networkx
had a broken build pushed to pypi that enabled installation of 3.2 on Python 3.8 (3.2 requires Python >= 3.9). This refines our optional requirements to explicitly exclude networkx 3.2 on Python < 3.9. This highlighted a bug in how we were doing version comparison insetup.py
Changes proposed in this PR:
openmpi
networkx
version for python<3.9GamsExceptionExecution
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: