Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track changes in PyPy behavior introduced in 7.3.14 #3087

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

jsiirola
Copy link
Member

Fixes # .

Summary/Motivation:

PyPy 7.3.14 changed how inspect behaves to diverge from CPython's behavior (see pypy/pypy#4839). This introduced a test failure in Pyomo. This PR resolves the test failure, by acknowledging that PyPy and CPython behave differently (and does NOT introduce hacks into Pyomo to make both platforms behave similarly)

Changes proposed in this PR:

  • Update tests to recognize / document that we will see different behavior on recent PyPy
  • Standardize the check of running under PyPy in other tests

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Contributor

@mrmundt mrmundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the explanatory comments. Also, this is annoying.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d04f6bb) 88.10% compared to head (131fd3f) 88.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3087      +/-   ##
==========================================
- Coverage   88.10%   88.09%   -0.01%     
==========================================
  Files         775      775              
  Lines       91549    91549              
==========================================
- Hits        80660    80652       -8     
- Misses      10889    10897       +8     
Flag Coverage Δ
linux 85.46% <ø> (ø)
osx 75.47% <ø> (ø)
other 85.64% <ø> (ø)
win 82.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrmundt mrmundt mentioned this pull request Jan 11, 2024
@jsiirola jsiirola merged commit a53bebc into Pyomo:main Jan 11, 2024
33 checks passed
@jsiirola jsiirola deleted the pypy-inspect-change branch January 11, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants