Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lbb solve_data bug #3133

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix lbb solve_data bug #3133

merged 1 commit into from
Feb 20, 2024

Conversation

ZedongPeng
Copy link
Contributor

Fixes #3132 .

Summary/Motivation:

The solve_data was designed to be removed in both gdpopt and mindtpy. This pull request addresses the omission by removing two instances of solve_data from the gdpopt.lbb code.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@emma58
Copy link
Contributor

emma58 commented Feb 13, 2024

@ZedongPeng, thank you for catching this! Could you please add a test for this fix too?

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (42fa578) 88.28% compared to head (dac2f31) 88.28%.
Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3133   +/-   ##
=======================================
  Coverage   88.28%   88.28%           
=======================================
  Files         832      832           
  Lines       92307    92307           
=======================================
  Hits        81495    81495           
  Misses      10812    10812           
Flag Coverage Δ
linux 86.04% <ø> (ø)
osx 75.55% <ø> (ø)
other 86.24% <ø> (ø)
win 83.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blnicho blnicho requested a review from emma58 February 13, 2024 19:43
Copy link
Contributor

@emma58 emma58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, though I'd prefer if you could also add a test that exercises it, @ZedongPeng

@blnicho blnicho merged commit 52ad602 into Pyomo:main Feb 20, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GDPOpt.LBB: name 'solve_data' is not defined
4 participants