-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solver Refactor Part 1: Introducing the new solver interface #3137
Conversation
…rsistentSolverUtils
updating results processing and tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still going through this but here are some initial comments
Consolidate log_solevr_output into tee
def parse_sol_file( | ||
sol_file: io.TextIOBase, nl_info: NLWriterInfo, result: Results | ||
) -> Tuple[Results, SolFileData]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should re-think this API and not pass the results in / out of this function. I would argue for this to be a parser that returns the parsed data, and populating a results object is the responsibility of the caller. This would also remove the somewhat confusing passing in / out of results objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. It's "rough" but not "as rough as it used to be" right meow.
Fixes #1030 (but not entirely)
Summary/Motivation:
This is a relatively large PR that introduces a refactored solver interface (placed in
contrib
as it is not yet the default behavior). Ideally, the intent behind this PR is to:Changes proposed in this PR:
keepfiles
)Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: