Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding private_data to _BlockData #3138

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Adding private_data to _BlockData #3138

merged 6 commits into from
Feb 16, 2024

Commits on Feb 14, 2024

  1. First draft of private data on Blocks

    @emma58
    emma58 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    4e8ef42 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Merge branch 'main' into add-mfe

    @emma58
    emma58 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    bcd6b66 View commit details
    Browse the repository at this point in the history

  2. Actually putting private_data on _BlockData (whoops), adding a kind o… 

    …f silly test
    @emma58
    emma58 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    95f005a View commit details
    Browse the repository at this point in the history

  3. Making _private_data the actual dict and doing away with the property

    @emma58
    emma58 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    cc54ae5 View commit details
    Browse the repository at this point in the history

  4. Ensuring private_data really is private by limiting the possible keys… 

    … to substrings of the caller's scope
    @emma58
    emma58 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    73977aa View commit details
    Browse the repository at this point in the history

  5. Whoops, removing comments

    @emma58
    emma58 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    170acb8 View commit details
    Browse the repository at this point in the history