-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add call_before_subproblem_solve callback in MindtPy #3251
Conversation
I confirm I was able to run this code 2 weeks ago to reproduce paper results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3251 +/- ##
==========================================
- Coverage 88.45% 88.45% -0.01%
==========================================
Files 849 852 +3
Lines 95329 98139 +2810
==========================================
+ Hits 84327 86808 +2481
- Misses 11002 11331 +329
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused that the docstrings say 'after' when I think the callback is 'before', but otherwise this looks fine.
Thank you @emma58 . I just corrected 'after' to 'before'. |
0c70946
to
add489c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, although it could be improved by adding a test that exercises the "new" option (adding the test will help ensure that we don't accidentally break the functionality in the future).
The callback test has been added. |
Summary/Motivation:
This Pull Request introduces the
call_before_subproblem_solve
callback in MindtPy, enabling customized warm-starts for solving NLP subproblems. This feature has been thoroughly tested by @jialuw96 and @adowling2.Changes proposed in this PR:
call_before_subproblem_solve
callback in MindtPyLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: