Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel: fix bug in conic geomean #3310

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Conversation

sadavis1
Copy link
Contributor

@sadavis1 sadavis1 commented Jul 8, 2024

Summary/Motivation:

pyomo.kernel.conic.primal_geomean.as_domain() does not work without a 2-character fix (dies in Mosek code). dual_geomean.as_domain() seems to have the same problem.

Changes proposed in this PR:

  • Fix _build_linking_constraints() call in previously mentioned methods

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (25d5910) to head (d77bb0d).
Report is 841 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3310   +/-   ##
=======================================
  Coverage   88.48%   88.49%           
=======================================
  Files         868      868           
  Lines       98433    98433           
=======================================
+ Hits        87103    87112    +9     
+ Misses      11330    11321    -9     
Flag Coverage Δ
linux 86.33% <100.00%> (+0.02%) ⬆️
osx 75.64% <100.00%> (+0.02%) ⬆️
other 86.51% <100.00%> (+0.02%) ⬆️
win 83.82% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsiirola jsiirola merged commit d085500 into Pyomo:main Jul 23, 2024
32 checks passed
@jsiirola jsiirola changed the title Conic geomean fix Kernel: fix bug in conic geomean Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants