Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move URL Checker to Weekly Job #3360

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Move URL Checker to Weekly Job #3360

merged 2 commits into from
Aug 22, 2024

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Aug 22, 2024

Fixes NA

Summary/Motivation:

We want URL checking, but we don't want it to cripple normal jobs. This moves the URL checker to happen weekly on Sunday.

Changes proposed in this PR:

  • Remove URL checker from regular test jobs
  • Create new weekly / Sunday night URL checker

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (b46a8e3) to head (33cd61d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3360   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files         879      879           
  Lines      100218   100218           
=======================================
+ Hits        88900    88901    +1     
+ Misses      11318    11317    -1     
Flag Coverage Δ
linux 86.27% <ø> (ø)
osx 76.04% <ø> (ø)
other 86.76% <ø> (ø)
win 84.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrmundt mrmundt requested a review from blnicho August 22, 2024 17:53
@mrmundt
Copy link
Contributor Author

mrmundt commented Aug 22, 2024

@jsiirola , @blnicho - added URL checking back to the branch job

@mrmundt mrmundt merged commit 59fe765 into Pyomo:main Aug 22, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants