Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPSI: disable sending output to logger by default #3521

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

michaelbynum
Copy link
Contributor

@michaelbynum michaelbynum commented Mar 12, 2025

Temporary fix for #3520.

Changes proposed in this PR:

  • In the APPSI solver interfaces, by default, do not send output to the logger.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@michaelbynum michaelbynum requested a review from jsiirola March 12, 2025 17:00
@michaelbynum michaelbynum changed the title disable sending highs output to logger by default APPSI: disable sending output to logger by default Mar 12, 2025
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 47.05882% with 18 lines in your changes missing coverage. Please review.

Project coverage is 86.43%. Comparing base (4da59c6) to head (4cff5ff).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pyomo/contrib/appsi/solvers/cplex.py 7.14% 13 Missing ⚠️
pyomo/contrib/appsi/solvers/cbc.py 75.00% 1 Missing ⚠️
pyomo/contrib/appsi/solvers/gurobi.py 75.00% 1 Missing ⚠️
pyomo/contrib/appsi/solvers/highs.py 75.00% 1 Missing ⚠️
pyomo/contrib/appsi/solvers/ipopt.py 75.00% 1 Missing ⚠️
pyomo/contrib/appsi/solvers/maingo.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3521      +/-   ##
==========================================
- Coverage   88.65%   86.43%   -2.22%     
==========================================
  Files         882      882              
  Lines      101090   101857     +767     
==========================================
- Hits        89619    88040    -1579     
- Misses      11471    13817    +2346     
Flag Coverage Δ
builders 26.63% <11.76%> (+0.01%) ⬆️
default 84.72% <47.05%> (?)
expensive 34.08% <11.76%> (?)
linux 69.62% <23.52%> (-18.78%) ⬇️
linux_other 69.62% <23.52%> (-16.47%) ⬇️
osx ?
win ?
win_other ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants