Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install killall,uninstall scripts into k3s_install_dir #224

Closed
wants to merge 1 commit into from

Conversation

qlonik
Copy link

@qlonik qlonik commented Jun 16, 2024

Install killall,uninstall scripts into k3s_install_dir

Summary

Installs killall and uninstall scripts into configured k3s_install_dir instead of hard-coded /usr/local/bin. This is a feature for TrueNAS scale Dragonfish, where /usr/ is now mounted readonly.

Closes #223

Issue type

  • Feature

Test instructions

Acceptance Criteria

Additional Information


@longns1
Copy link
Contributor

longns1 commented Jul 18, 2024

I think we should use a different variable for this instead of the k3s_install_dir variable.

Copy link

stale bot commented Oct 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 5, 2024
@ayr-ton ayr-ton self-requested a review October 15, 2024 19:57
@stale stale bot removed the wontfix This will not be worked on label Oct 15, 2024
Copy link
Collaborator

@ayr-ton ayr-ton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing your code. 🥲

This contribution sounds great. 💪 However, could you change to have a default k3s_install_dir as /usr/local/bin? Then it will work for everyone.

Copy link

stale bot commented Jan 3, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 3, 2025
@stale stale bot closed this Jan 11, 2025
@qlonik
Copy link
Author

qlonik commented Jan 12, 2025

Hey, sorry for late responses.

@ayr-ton Where does the default value need to be specified? I saw in this file defaults/main.yml#L45 that there is already a default for this variable and assumed that I don't need to set a default value anywhere else.

@longns1 I thought k3s_install_dir defaults to /usr/local/bin as well as the fact that all other binaries are installed into this folder too. By reusing the same variable we will keep them together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install killall and uninstall scripts into k3s_install_dir
3 participants