Added support for ByteString in _restore_typed_primitive
#279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to bugfix/extended-cip8
|
Please run |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #279 +/- ##
==========================================
- Coverage 84.74% 84.63% -0.12%
==========================================
Files 26 26
Lines 3067 3071 +4
Branches 750 752 +2
==========================================
Hits 2599 2599
- Misses 350 353 +3
- Partials 118 119 +1
|
|
That's what I get for being lazy. Ready to go. |
cffls
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a bug where restoring a datum after serialization cannot handle ByteString.
This PR fixes the issue.
I'm glad a release hasn't been pushed yet :)