-
-
Notifications
You must be signed in to change notification settings - Fork 79
WIP: CIP67 and CIP68 Support #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WIP: CIP67 and CIP68 Support #297
Conversation
…to bugfix/extended-cip8
Bugfix/bytestring
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
===========================================
- Coverage 89.94% 65.42% -24.53%
===========================================
Files 33 35 +2
Lines 4855 4957 +102
Branches 733 748 +15
===========================================
- Hits 4367 3243 -1124
- Misses 315 1516 +1201
- Partials 173 198 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
So we just need some kind of extension of this? pycardano/pycardano/serialization.py Line 806 in 3d27786
Have any examples? I just did a query of all cip68 reference tokens and found that 99.99% of them are nfts. I'm trying to figure out a good set of test cases for it. I could use the example in the CIP68 docs, but those are extremely sparse. Ideally I could get a range of different examples. |
I would rather extend the support of type annotations for fields of PlutusData here: Line 681 in 3d27786
Also for the CIP68 datum I meant the deserialization happening when submitting a transaction with a CIP68 Datum attached - you can try this yourself easily. But don't have any examples at hand right now except for https://preprod.cardanoscan.io/transaction/36f79154eff88d73c21caaf9c5e1bedfc1ff641e39f7f80381dbdba0c104bc50 |
I'll be working on finishing this off. Todo:
|
Feat/cip67 cip68
- Switched to TypedDicts for metadata classes - Added PlutusData wrapper class and tests
…dano into feat/cip67-cip68
Feat/cip67 cip68
@cffls We are close to having something ready. Just need to get builds passing. |
This PR is a first pass implementation at handling classes for CIP67 and CIP68. These classes will streamline handling and parsing tokens utilizing these standards. This approach attempts to extend
AssetName
by providing additional validation to ensure CIP68 compliance for token names, as well as associated cbor classes for parsing associated metadata.Feedback on implementation details and additional functionality is welcomed.
Todo:
uri
fields)