Allow subtracting assets if not existing before #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negative values were allowed before as well so it is only consequential to allow subtracting from 0
|
IIRC, I added the check because I didn't think net negative asset was possible in a finalized output. I am fine with this change. We should also add a check in txbuilder for negative asset if there isn't one today. |
cffls
approved these changes
Feb 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative values were allowed before as well so it is only consequential to allow subtracting from 0. This simplifies edge case handling for tools that simply want to operate on Values. Is there any inherent rule/implementation in the ledger that lead to the previous error situation?