Skip to content

Make vkey witnesses None when empty #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Make vkey witnesses None when empty #377

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fca0337
Set vkey witnesses to None when empty
theeldermillenial Sep 22, 2024
892d610
Merge branch 'chang' of https://github.com/python-cardano/pycardano i…
theeldermillenial Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pycardano/txbuilder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1509,4 +1509,7 @@
VerificationKeyWitness(signing_key.to_verification_key(), signature)
)

if len(witness_set.vkey_witnesses) == 0:
witness_set.vkey_witnesses = None

Check warning on line 1513 in pycardano/txbuilder.py

View check run for this annotation

Codecov / codecov/patch

pycardano/txbuilder.py#L1513 

Added line #L1513 was not covered by tests

return Transaction(tx_body, witness_set, auxiliary_data=self.auxiliary_data)
Loading