-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs erroneously say that odict.add()
only has two mandatory parameters
#554
Comments
Not sure why the docs say "optional". It never has been and doesn't make sense to be. I'll update the docs. Thanks for the report. |
Thanks! Can you publish the doc update? http://pythonhosted.org/Markdown/extensions/api.html#ordereddict still says "Optional." |
The docs are updated on each release. |
Hmm, looks like we didn't update the docs when we released 2.6.9. Opps. |
Docs don't auto-deploy on release? I figured they did, but I never really checked. |
No, I never got that automated. The releases are so few and far between and it was never a problem to run |
Have you settled on a theme? If you have (and when I have some time), I can probably set it up. |
That is of course if you are ready to jump to Mkdocs. |
The switch to MkDocs exists in the md3 branch at 6f87b32. That commit should "cherry-pick" and merge relatively easily. And I just finished and released the MkDocs-Nature theme to use with it (the md3 branch is currently using readthedocs). Whoever gets to it first... |
Quoting from the Extension API docs (emphasis mine):
But the source code for the method shows that all three arguments are required:
Either the "Optional" should be removed from the docs, or the parameter should be made optional.
I’d mildly prefer the latter, as I have some cases where the location really doesn’t matter, but it’s not a strong preference.
The text was updated successfully, but these errors were encountered: