Skip to content

TOC: Support HTML H* elements #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
balupton opened this issue Jun 5, 2019 · 1 comment
Closed

TOC: Support HTML H* elements #829

balupton opened this issue Jun 5, 2019 · 1 comment
Labels
3rd-party Should be implemented as a third party extension. feature Feature request.

Comments

@balupton
Copy link

balupton commented Jun 5, 2019

Currently the TOC completely falls over if the markdown document has HTML H* elements, such as <h1 id="header-1">Header 1</h1><h2 id="header-2">Header 2</h2>.

For my particular use case, I have one markdown file that is generated HTML code from API documentation, that we want rendered into the rest of the documentation - it renders fine - but no TOC.
balupton added a commit to textileio/community that referenced this issue Jun 5, 2019
@balupton
latest textile CLI documentation
13970c6 
closes #88

- moves from makefile to bash scripts (would use npm scripts, but seems textile tries to avoid that), as makefile does not support what is necessary for the build script

- there is no TOC for the CLI page due to these bugs:

    Python-Markdown/markdown#830

    Python-Markdown/markdown#829

- adds the editorconfig from textileio/base

Signed-off-by: Benjamin Lupton <b@lupton.cc>
@balupton balupton mentioned this issue Jun 5, 2019
Merged
@waylan waylan added 3rd-party Should be implemented as a third party extension. feature Feature request. labels Jun 5, 2019
@waylan
Copy link
Member

waylan commented Jun 5, 2019

While I understand the desire for this feature, it would be extremely difficult to implement given how the raw HTML is handled. Personally, I have no interest in doing the work. Therefore, I am closing this as something which can be implemented as a third party extension.

@waylan waylan closed this as completed Jun 5, 2019
balupton added a commit to textileio/community that referenced this issue Jun 5, 2019
@balupton
latest textile CLI documentation
9944bbc 
closes #88

- moves from makefile to bash scripts (would use npm scripts, but seems textile tries to avoid that), as makefile does not support what is necessary for the build script

- there is no TOC for the CLI page due to these bugs:

    Python-Markdown/markdown#830

    Python-Markdown/markdown#829

- adds the editorconfig from textileio/base

Signed-off-by: Benjamin Lupton <b@lupton.cc>
balupton added a commit to textileio/community that referenced this issue Jun 5, 2019
@balupton
latest textile CLI documentation (#93)
6ce6c85 
closes #88

- moves from makefile to bash scripts (would use npm scripts, but seems textile tries to avoid that), as makefile does not support what is necessary for the build script

- there is no TOC for the CLI page due to these bugs:

    Python-Markdown/markdown#830

    Python-Markdown/markdown#829

- adds the editorconfig from textileio/base

Signed-off-by: Benjamin Lupton <b@lupton.cc>
@balupton balupton mentioned this issue Jun 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3rd-party Should be implemented as a third party extension. feature Feature request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@balupton @waylan