Allow attr_list quoted values to contain curly braces #1414
Conversation
How it worked before:
* Extract the content without allowing any `}` in it, and require that it ends with `}` - for block elements anchored to the end of the line, otherwise not.
* Parse the content in more detail. No edge cases with `}` can arise. If parsing is interrupted by some unrecognized token, discard the rest of the string.
How it works now:
* Extract the content *and allow* `}` in it, and require that it ends with `}` - for block elements it's anchored to the end of the line, otherwise not.
* Parse the content in more detail. Allow `}` only within the quoted parts, otherwise interrupt parsing like for any other unrecognized token.
If parsing is interrupted, there is remaining unrecognized text. Ideally perhaps we would bail out at this point entirely (and not recognize it as an attr_list), but to preserve historic behavior, any extra text before `}` is just discarded.
If there is an extra `}` in the remaining text:
* For block elements: that must mean that the attr_list syntax did not in fact terminate at the end of the line but earlier. So, bail out and do not register any attributes and do not change the original text.
* For inline elements: that must mean that we just overmatched a bit, but that's OK, we just assign attrs as normal and put the extra text back into the string. As mentioned, any extra text *before* `}` is just discarded.
|
I'm quite happy and confident with this change, and actually it preserves prior behavior very well in cases that were already recognized as an attr_list. (As evidenced by not needing to change anything in existing test cases). |
There was a problem hiding this comment.
I thought we added this to the Contributing Guide, but I can't find it now. In any event, it has been our policy for some time that whenever we need to add/edit tests, that they be moved to the new testing framework rather then be added to or edited in the legacy framework. In other words, in this case, the new test should be in test_syntax/extensions/test_attr_list.py
Otherwise, generally speaking I think this is a reasonable approach. However, I have not considered the specifics closely yet. I will come back to this this later (probably in a week or more as I am unavailable the rest of this week).
|
I think the "legacy" approach is way more developer-friendly. I don't want to develop a new test file. If that's a blocker, I hope someone can help out with a commit based on this one. |
|
The test file already exists. I even pointed to it, but here it is again |
|
In this comment I stated:
"All elements" includes fenced code blocks (which is clear if you read the proceeding paragraph). However, fenced code blocks have not been addressed here at all. Note that I have added a relevant test, which is currently failing. That test, and potentially some other similar (yet to be created) tests need to be passing before the stated requirements are met. |
|
Thanks for the test. OK let me quickly check that out. |
|
Alright, done! Note: For all others, preexisting behavior is preserved. |
waylan
added
approved
How it worked before:
}in it, and require that it ends with}- for block elements anchored to the end of the line, otherwise not.}can arise. If parsing is interrupted by some unrecognized token, discard the rest of the string.How it works now:
}in it, and require that it ends with}- for block elements it's anchored to the end of the line, otherwise not.}only within the quoted parts, otherwise interrupt parsing like for any other unrecognized token.If parsing is interrupted, there is remaining unrecognized text. Ideally perhaps we would bail out at this point entirely (and not recognize it as an attr_list), but to preserve historic behavior, any extra text before
}is just discarded.If there is an extra
}in the remaining text:}is just discarded.