-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Up version to 3.1.dev0 #736
Conversation
Also update to be PEP 440 compliant in preparation for Python-Markdown#732.
Just a note that [pypa/packaging] officially implements PEP 404. And as of pypa/setuptools@9382fa0c, (version 8.0) Therefore, the differences between |
Hmm, not sure why we are only getting this error on Python 3.4:
|
There was a period of time when setuptools did not ship Namely, it was:
So requiring |
I also want to mention that with this PR, Python-Markdown needs a fresh version of
|
Never knew about the toml file. I've had to use |
Yeah the toml file is relatively new. I have considered switching to it, but didn't see any added value till this issue.
Ah, that was the detail I was missing. Thanks for pointing that out. At least we have a clear path to a solution now. |
Adding the
|
I think tox supports toml https://tox.readthedocs.io/en/latest/example/package.html?highlight=toml#setuptools. Maybe I'm mistaken? |
Finally got Travis to pass. There are multiple moving parts here:
|
Looks like I got this all working. A few final notes. Unfortunately, there does not seem to be a way to tell tox how to build the lib. There is an Apparently we could define the tox config in the |
Your last changes look good to me. Thanks! |
See tox-dev/tox#850. Apparently, with the changes in tox-dev/tox#954, wheel support can be added via a third-party plugin (which doesn't exist yet AFAICT). The reasons for this approach are discussed in detail in tox-dev/tox#573. If/when such a plugin becomes available, we should adopt it for our tests. |
Depending on private, internal API of setuptools results in bugs like #825 |
Also update to be PEP 440 compliant in preparation for #732.