Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default ABI version doesn't match SIP ones #25

Closed
troopa81 opened this issue Dec 18, 2024 · 3 comments
Closed

Default ABI version doesn't match SIP ones #25

troopa81 opened this issue Dec 18, 2024 · 3 comments
Assignees
@philthompson10
Labels
bug Something isn't working

Comments

@troopa81
Copy link

PyQt-builder default abi versions doesn't match SIP ones 12 13
@troopa81 troopa81 mentioned this issue Dec 18, 2024
Open
@philthompson10 philthompson10 added the bug Something isn't working label Dec 18, 2024
@philthompson10 philthompson10 self-assigned this Dec 18, 2024
philthompson10 added a commit to philthompson10/PyQt-builder that referenced this issue Dec 18, 2024
@philthompson10
Updated the default ABIs used
4df8b97 
The default ABIs used have been updated to match those supported by SIP
v6.9.

Resolves Python-PyQt#25
@philthompson10
Copy link
Contributor

These have been updated but it doesn't actually matter if they are not set to the latest versions. If a project needs a specific minimum version then they should explicitly set it their pyproject.toml.

@troopa81 troopa81 mentioned this issue Dec 23, 2024
Merged
@philthompson10
Copy link
Contributor

In fact the specification of any minor number is confusing, somewhat arbitrary and unnecessary. It should be left to SIP to decide on a default minor number - PyQt-builder only needs to provide a default major number (ie. 12 or 13).

@philthompson10 philthompson10 mentioned this issue Dec 24, 2024
Closed
philthompson10 added a commit to philthompson10/PyQt-builder that referenced this issue Dec 24, 2024
@philthompson10
Updated the default ABIs used
14bb078 
The default ABI used now only specifies the major version.  It is left to
SIP to provide an appropriate minor version.

Resolves Python-PyQt#25
@philthompson10
Copy link
Contributor

See issue #28 for a better description and resolution of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philthompson10 philthompson10

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@troopa81 @philthompson10