Fix code caching for OpenMP regions (CPU and GPU) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DrTodd13
commented
Jul 11, 2024
DrTodd13
commented
- Fix dispatcher pickling to only return output_types if it is a object mode lifted with.
- Move openmp library opening to the first openmp compilation or the first time a cached openmp function is loaded.
- Make openmp_tag pickleable by not storing the arg if it contains a llvmlite AllocaInstr.
ggeorgakoudis
requested changes
Sep 4, 2024
|
Pause on this branch @DrTodd13. I'm restructuring numba to remove distributing llvm-tools and libraries and use instead |
|
@DrTodd13 can we revive this PR on the latest develop version? |
DrTodd13
force-pushed
the
lazy_lib_init
branch
2 times, most recently
from
6f02329 to
610f45a
Compare
ggeorgakoudis
changed the title
DrTodd13
force-pushed
the
lazy_lib_init
branch
from
610f45a to
4314970
Compare
…ect mode lifted with. 2) Make openmp_tag pickleable by not storing the arg if it contains a llvmlite AllocaInstr. 3) Don't pickle anything for LiftedCode's function IR except the arg count and the func_id. 4) Return all of openmp_region_start for pickling. 5) Comment on why we need new class.
ggeorgakoudis
force-pushed
the
lazy_lib_init
branch
from
c00c71b to
7f1ef40
Compare
|
@DrTodd13 Rebased on a more recent |
ggeorgakoudis
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.