feat(exceptions): Implement custom HTTP exceptions and global FastAPI… #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exception handler to Pynest - Add HttpException base class for custom HTTP exceptions - Create specific exception classes for common HTTP status codes - Implement FastAPI exception handlers for consistent JSON responses - Integrate custom exceptions with Pynest routes for improved error handling
ItayTheDar
requested changes
Jul 31, 2024
| "status_code": status_code | ||
| } | ||
|
|
||
| def test_exceptions_inheritance(): |
There was a problem hiding this comment.
Can you please create test for every custom exception?
| @@ -1,3 +1,5 @@ | |||
| from http import HTTPStatus | |||
There was a problem hiding this comment.
Please create a md file under docs that demonstrate the usage of the different exceptions, documentation is the most important part of it because this is how people are going to use those pieces of code. After creating the markdown, add it to the static docs site under the mkdosc.yml file
Write Tests for All Pynest HTTP Custom Exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… exception handler to Pynest