Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
rewrite some of the decrator utils.
By converting for loops into list, dict comprehension , I've a lot of wrapped try, exception section inside the loop with re-raise, I've removed them (there is no unique logic inside the exception block).
Original
Changed
Forthermore, I've seen duplicate code inside get_instance_variables where the dependencies is already written inside parse_dependencies.
I didn't understand why the need to check only object ( not including inherited attributes) however I assume a usage and created another argument for parse_dependencies to decide which check to activate.
and got:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Refactors and optimizes utility functions in the
nest/core/decorators/utils.py
file. Converts for loops into list and dictionary comprehensions, removes unnecessary try-except blocks, and introduces type hints. Adds new helper functions to improve code readability and maintainability. Modifies theparse_dependencies
function to handle both inherited and non-inherited injectable attributes.Modified files (1)
Latest Contributors(2)
Modified files (1)
Latest Contributors(2)