Skip to content

barycenter_sinkhorn possible mistake #134

@FerdinandGns

Description

@FerdinandGns

Hello everyone,
It seems that there is a mistake in ot/bregman.py for the following function:
barycenter_sinkhorn
line 1123 : u = (geometricMean(UKv) / UKv.T).T
geometricMean(UKv) should be replaced by geometricBar(UKv, weights) if we do as in: https://github.com/gpeyre/2014-SISC-BregmanOT/tree/master/code/barycenters
(I tested with Gaussians, and it seems that I am correct)

Best regards

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions