[MRG] Generalized Wasserstein Barycenters #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rflamary
changed the title
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
+ Coverage 93.78% 93.85% +0.07%
==========================================
Files 23 23
Lines 5902 5926 +24
==========================================
+ Hits 5535 5562 +27
+ Misses 367 364 -3 |
rflamary
changed the title
agramfort
reviewed
May 8, 2022
| @@ -137,6 +137,7 @@ def test_partial_wasserstein(): | |||
|
|
|||
|
|
|||
| def test_partial_gromov_wasserstein(): | |||
| np.random.seed(42) | |||
There was a problem hiding this comment.
@eloitanguy @rflamary you should not use global seeds in tests. It makes tests coupled as they share a random state. It may happen that a test that does not control its seed fails only if run after another test and it makes debugging a nightmare. You should np.random.default_rng these days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
generalized_free_support_barycentersolver inot/lp/__init__.py(next tofree_support_barycenter)examples/barycenters/plot_generalized_free_support_barycenter.pyfree_support_barycenter(mis-numbered/missing references + added details on variable names)Motivation and context / Related issue
Implements the article "Generalised Wasserstein Barycenter" [42]
[42] DELON, Julie, GOZLAN, Nathael, et SAINT-DIZIER, Alexandre.
Generalized Wasserstein barycenters between probability measures living on different subspaces.
arXiv preprint arXiv:2105.09755, 2021.
How has this been tested (if it applies)
Added tests in
tests_ot.py, accounting for dimensionality, optional arguments and backendsPR checklist