[MRG] numItermax in 64 bits in EMD solver #380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Motivation and context / Related issue
When the OpenMP version of EMD was added, the computation of the plan was converted to 64 bits. However, one variable was forgotten, which is the max number of iterations. In the C code, it is a size_t variable, hence usually 64 bits, but the Cython link between C and Python uses an int to store the value. I intend to make it 64 bits as well to allow high numbers of iterations.
How has this been tested (if it applies)
I run all tests on Jean Zay.
PR checklist