Skip to content

[MRG] Fix barycenter_stabilized with PyTorch and log set to True #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2023
Merged

[MRG] Fix barycenter_stabilized with PyTorch and log set to True #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67f429e
np -> nx for stabilized barycenters log
kachayev May 5, 2023
04eb0b9
Mention fix in RELEASES
kachayev May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- Fix gradients for "Wasserstein2 Minibatch GAN" example (PR #466)
- Faster Bures-Wasserstein distance with NumPy backend (PR #468)
- Fix issue backend for ot.sliced_wasserstein_sphere ot.sliced_wasserstein_sphere_unif (PR #471)
- Fix issue with ot.barycenter_stabilized when used with PyTorch tensors and log=True (RP #474)

## 0.9.0

Expand Down
4 changes: 2 additions & 2 deletions ot/bregman.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1898,8 +1898,8 @@ def barycenter_stabilized(A, M, reg, tau=1e10, weights=None, numItermax=1000,
"Or a larger absorption threshold `tau`.")
if log:
log['niter'] = ii
log['logu'] = np.log(u + 1e-16)
log['logv'] = np.log(v + 1e-16)
log['logu'] = nx.log(u + 1e-16)
log['logv'] = nx.log(v + 1e-16)
return q, log
else:
return q
Expand Down