[MRG] Add a geomloss wrapper for sinkhorn solver #571
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
This is a first attempt to build on the awesome geomloss and Keops of @jeanfeydy. this function
empirical_sinkhorn2_geomloss
is a simple wrapper that will be called inot.sovle_sample
withmethod='geomloss'
.The computational time returned by the script above on CPU only machine are:
For the moment this solver is compatible only with pytorch and numpy (with pytorch conversion)
Motivation and context / Related issue
How has this been tested (if it applies)
PR checklist