Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/queue redesign (New Queue implementation) #280

Merged
merged 8 commits into from
Feb 3, 2024

Conversation

EvieePy
Copy link
Member

@EvieePy EvieePy commented Feb 3, 2024

Description

Adds a new implementation of wavelink.Queue. Most of this design is reused from @Sachaa-Thanasius in #255

I have tested this pretty extensively both with and without a bot and everything seems to be behaving as it should.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

wavelink/queue.py Outdated Show resolved Hide resolved
wavelink/queue.py Outdated Show resolved Hide resolved
Copy link
Member

@Sachaa-Thanasius Sachaa-Thanasius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Had a small discussion in Discord about a previously mentioned max_retention variable for bounding the history queue's (or all queues's) length, but that can be developed in another PR if it's deemed worthy.

@chillymosh chillymosh merged commit eeec649 into main Feb 3, 2024
5 checks passed
@chillymosh chillymosh deleted the feature/queue-redesign branch February 3, 2024 16:05
@chillymosh chillymosh mentioned this pull request Feb 3, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants