Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/autoplay queue #282

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Fix/autoplay queue #282

merged 5 commits into from
Feb 7, 2024

Conversation

EvieePy
Copy link
Member

@EvieePy EvieePy commented Feb 7, 2024

Description

Fixes a logic error that would randomize the auto_queue everytime tracks were added instead of just randomizing the tracks that are added.

Fixes an issue where the player might not play the next track in auto_queue if it can't find new tracks (even when there are tracks in auto_queue).

Fixes an issue where the player plays the next track before the auto_queue has completed adding its tracks. Although this isn't really a bug it's probably a bad way of doing things as when systems rely on updates in track_start auto_queue could be outdated/incomplete.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

@EvieePy EvieePy added the bug Something isn't working label Feb 7, 2024
Copy link
Contributor

@chillymosh chillymosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvieePy EvieePy merged commit 90b1da8 into main Feb 7, 2024
5 checks passed
@EvieePy EvieePy deleted the fix/autoplay-queue branch February 7, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants