WorldGuard Flag Registration Failed

[Sidpatchy]

Issue opened on behalf of Spigot reviewer: https://www.spigotmc.org/resources/anti-world-fly.5357/reviews#review-576854-2107827

Plugin Version: 2.5.4

Minecraft Version: 1.21.1

Spigot/CraftBukkit version: Leaf

• Not sure how this is different from Paper, first thing is to check if the issue is present on Spigot and Paper. If the issue is with Leaf I am not particularly interested in supporting breaking changes to the Spigot/Paper API.

Other Plugins you are using:

• WorldGuard 7.0.13
• PlugManX 2.4.1
  • This seems most likely to be the cause of the issue from the initial glance I've had at the logs provided. It appears to be replacing the default plugin loader?

Current Behavior

Plugin fails to load with java.lang.IllegalStateException: New flags cannot be registered at this time when attempting to register WorldGuard flags.

Steps to Reproduce

(These are the assumed steps to reproduce based off the logs provided in the review)

1. Have WorldGuard 7.0.13 installed and running
2. Use PlugManX 2.4.1(???) to load AntiWorldFly-2.5.4 after server's initial startup(???)
3. Plugin fails to initialize during the flag registration process

Context (Environment)

Detailed Description

Comment from review:

it would be nice if there was no spam error, I hope it will be fixed

Error logs from review:

[16:28:13 ERROR]: [AntiWorldFly] Error initializing plugin 'AntiWorldFly-2.5.4-1754314093349.jar' in folder 'plugins\.paper-remapped\unknown-origin' (Is it up to date?)
java.lang.IllegalStateException: New flags cannot be registered at this time
at worldguard-bukkit-7.0.13-dist.jar/com.sk89q.worldguard.protection.flags.registry.SimpleFlagRegistry.register(SimpleFlagRegistry.java:60) ~[worldguard-bukkit-7.0.13-dist.jar:?]
at AntiWorldFly-2.5.4-1754314093349.jar/com.hm.antiworldfly.worldguard.FlagRegistry.register(FlagRegistry.java:22) ~[AntiWorldFly-2.5.4-1754314093349.jar:?]
at AntiWorldFly-2.5.4-1754314093349.jar/com.hm.antiworldfly.AntiWorldFly.onLoad(AntiWorldFly.java:105) ~[AntiWorldFly-2.5.4-1754314093349.jar:?]
at io.papermc.paper.plugin.storage.ServerPluginProviderStorage.processProvided(ServerPluginProviderStorage.java:59) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at io.papermc.paper.plugin.manager.SingularRuntimePluginProviderStorage.processProvided(SingularRuntimePluginProviderStorage.java:62) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at io.papermc.paper.plugin.manager.SingularRuntimePluginProviderStorage.processProvided(SingularRuntimePluginProviderStorage.java:24) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at io.papermc.paper.plugin.storage.SimpleProviderStorage.enter(SimpleProviderStorage.java:39) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at io.papermc.paper.plugin.manager.SingularRuntimePluginProviderStorage.enter(SingularRuntimePluginProviderStorage.java:57) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at io.papermc.paper.plugin.manager.RuntimePluginEntrypointHandler.enter(RuntimePluginEntrypointHandler.java:40) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.loadPlugin(PaperPluginInstanceManager.java:116) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?]
at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?]
at PlugManX-2.4.1.jar/com.rylinaux.plugman.pluginmanager.PaperPluginManager.load(PaperPluginManager.java:399) ~[PlugManX-2.4.1.jar:?]
at PlugManX-2.4.1.jar/com.rylinaux.plugman.command.LoadCommand.execute(LoadCommand.java:114) ~[PlugManX-2.4.1.jar:?]
at PlugManX-2.4.1.jar/com.rylinaux.plugman.PlugManCommandHandler.onCommand(PlugManCommandHandler.java:94) ~[PlugManX-2.4.1.jar:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[leaf-api-1.21.4-R0.1-SNAPSHOT.jar:?]
at io.papermc.paper.command.brigadier.bukkit.BukkitCommandNode$BukkitBrigCommand.run(BukkitCommandNode.java:82) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.3.10.jar:?]
at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:29) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:13) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.commands.execution.UnboundEntryAction.lambda$bind$0(UnboundEntryAction.java:8) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.commands.execution.CommandQueueEntry.execute(CommandQueueEntry.java:5) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.commands.execution.ExecutionContext.runCommandQueue(ExecutionContext.java:103) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.commands.Commands.executeCommandInContext(Commands.java:430) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.commands.Commands.performCommand(Commands.java:362) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.commands.Commands.performCommand(Commands.java:353) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.commands.Commands.performCommand(Commands.java:347) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.server.network.ServerGamePacketListenerImpl.performUnsignedChatCommand(ServerGamePacketListenerImpl.java:2305) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$15(ServerGamePacketListenerImpl.java:2278) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.server.TickTask.run(TickTask.java:18) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:155) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1495) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:165) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:129) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1476) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1470) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:139) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.server.MinecraftServer.managedBlock(MinecraftServer.java:1425) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1434) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1314) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:300) ~[leaf-1.21.4.jar:1.21.4-516-e31d158]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

[Sidpatchy]

https://github.com/Test-Account666/PlugManX