Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][connector] Elastic Search Sink can now handle raw Record #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JeffBolle
Copy link

@JeffBolle JeffBolle commented Jun 20, 2023

Fixes apache#20619

Motivation

Sink pre-processing functions introduced in PIP 193 (apache#16739) can allow for producing a Record from the function that does not have a GenericObject, and instead is a String or byte[]. The current implementation of the ElasticSearch sink doesn't handle this situation cleanly. Additionally, the setting of the id of the ElasticSearch document from the Record key is incomplete in some cases.

Modifications

Modified the extractIdAndDocument method to create a GenericObject from the Record value if it isn't already.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added unit tests in ElasticSearchRawRecordTests

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: [https://github.com//pull/1]

[improve][connector] Elastic Search Sink can now handle raw Record types apache#20619
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElasticSearch Sink Improvements
1 participant