[improve][connector] Elastic Search Sink can now handle raw Record #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache#20619
Motivation
Sink pre-processing functions introduced in PIP 193 (apache#16739) can allow for producing a Record from the function that does not have a
GenericObject
, and instead is aString
orbyte[]
. The current implementation of the ElasticSearch sink doesn't handle this situation cleanly. Additionally, the setting of the id of the ElasticSearch document from the Record key is incomplete in some cases.Modifications
Modified the
extractIdAndDocument
method to create aGenericObject
from theRecord
value if it isn't already.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: [https://github.com//pull/1]