Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated methods #107

Merged
merged 1 commit into from
May 25, 2022
Merged

remove deprecated methods #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions broadbean/blueprint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

import numpy as np

from .broadbean import PulseAtoms, marked_for_deletion
from .broadbean import PulseAtoms


class SegmentDurationError(Exception):
Expand Down Expand Up @@ -680,10 +680,6 @@ def removeSegment(self, name):

self._namelist = self._make_names_unique(self._namelist)

@marked_for_deletion(replaced_by='broadbean.plotting.plotter')
def plot(self, SR=None):
pass

def __add__(self, other):
"""
Add two BluePrints. The second argument is appended to the first
Expand Down
5 changes: 0 additions & 5 deletions broadbean/broadbean.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,3 @@ def __getitem__(self, key):
return output

raise KeyError('Key must be int or slice!')


@marked_for_deletion(replaced_by='broadbean.plotting.plotter')
def bluePrintPlotter(blueprints, fig=None, axs=None):
pass
6 changes: 1 addition & 5 deletions broadbean/element.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import numpy as np
import json

from .broadbean import marked_for_deletion, PulseAtoms
from .broadbean import PulseAtoms
from broadbean.blueprint import BluePrint, _subelementBuilder


Expand Down Expand Up @@ -433,10 +433,6 @@ def copy(self):
new._meta = deepcopy(self._meta)
return new

@marked_for_deletion(replaced_by='broadbean.plotting.plotter')
def plotElement(self):
pass

def __eq__(self, other):
if not isinstance(other, Element):
return False
Expand Down
10 changes: 0 additions & 10 deletions broadbean/sequence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,11 @@
import numpy as np
from schema import Schema, Or, Optional
import json
import re

from broadbean.ripasso import applyInverseRCFilter
from broadbean.element import Element # TODO: change import to element.py
from broadbean.blueprint import BluePrint
from .broadbean import _channelListSorter # TODO: change import to helpers.py
from .broadbean import marked_for_deletion
from .broadbean import PulseAtoms
from .broadbean import _AWGOutput

Expand Down Expand Up @@ -677,14 +675,6 @@ def _plotSummary(seq: Dict[int, Dict]) -> Dict[int, Dict[str, np.ndarray]]:

return output

@marked_for_deletion(replaced_by='broadbean.plotting.plotter')
def plotSequence(self) -> None:
pass

@marked_for_deletion(replaced_by='broadbean.plotting.plotter')
def plotAWGOutput(self):
pass

def forge(self, apply_delays: bool=True,
apply_filters: bool=True,
includetime: bool=False) -> Dict[int, Dict]:
Expand Down