Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize setup and build infrastructure #109

Merged
merged 49 commits into from
Jun 9, 2022
Merged

Modernize setup and build infrastructure #109

merged 49 commits into from
Jun 9, 2022

Conversation

trevormorgan
Copy link
Contributor

@trevormorgan trevormorgan commented Jun 3, 2022 •
edited
Loading

  • Convert to pep517 compatible project (pyproject.toml)
  • Build wheels and sdist using build
  • Automatic upload to pypi
  • Move config to pyproject.toml and setup.cfg
  • pin dependencies with requirements.txt

@trevormorgan trevormorgan added this to the version 0.11.0 milestone Jun 3, 2022
Trevor Morgan and others added 13 commits June 2, 2022 23:45
update setup.cfg package_dir
22aa4b5
more setup,cfg updates
65cceed
@astafan8
Update setup.py
f703967
@astafan8
Update _version.py
c8e1294
Merge branch 'trmorgan/update-build-setup' of https://github.com/QCoD…
57f9b78 
…eS/broadbean into trmorgan/update-build-setup
@astafan8
Update pyproject.toml
407eb57
Merge branch 'trmorgan/update-build-setup' of https://github.com/QCoD…
fd175de 
…eS/broadbean into trmorgan/update-build-setup
@astafan8
Update setup.cfg
87cadfa
@astafan8
Update setup.cfg
a63553b
Merge branch 'trmorgan/update-build-setup' of https://github.com/QCoD…
1a07c3c 
…eS/broadbean into trmorgan/update-build-setup
@astafan8
Update pyproject.toml
3e710db
Merge branch 'trmorgan/update-build-setup' of https://github.com/QCoD…
9804629 
…eS/broadbean into trmorgan/update-build-setup
@astafan8
Update _version.py
1db0609
jenshnielsen
jenshnielsen reviewed Jun 3, 2022
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
jenshnielsen
jenshnielsen reviewed Jun 3, 2022
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
jenshnielsen
jenshnielsen reviewed Jun 3, 2022
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022 •
edited
Loading

Codecov Report

Merging #109 (b0b194e) into master (b73dd8d) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   79.90%   79.75%   -0.16%     
==========================================
  Files          15       16       +1     
  Lines        2359     2366       +7     
==========================================
+ Hits         1885     1887       +2     
- Misses        474      479       +5
Impacted Files Coverage Δ
broadbean/_version.py 0.00% <0.00%> (ø)
broadbean/sequence.py 72.26% <0.00%> (+0.20%) ⬆️
broadbean/tests/test_awgfilegeneration.py 97.14% <0.00%> (+1.42%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

astafan8
astafan8 approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! after merging this, let's not forget to tag a 0.11.0dev1 release to ensure that the publishing pipeline works correctly :)

astafan8
astafan8 reviewed Jun 7, 2022
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
@jenshnielsen
Copy link
Contributor

@trevormorgan The requirements.txt file has been created as UTF-16 please convert that to UTF-8

jenshnielsen
jenshnielsen reviewed Jun 7, 2022
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
Dominik-Vogel
Dominik-Vogel approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@Dominik-Vogel Dominik-Vogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

.github/workflows/pytest.yaml Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
jenshnielsen
jenshnielsen reviewed Jun 9, 2022
View reviewed changes
setup.cfg Show resolved Hide resolved
@trevormorgan trevormorgan merged commit 3ce94cc into master Jun 9, 2022
@trevormorgan trevormorgan deleted the trmorgan/update-build-setup branch June 9, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dominik-Vogel Dominik-Vogel Dominik-Vogel approved these changes

@astafan8 astafan8 astafan8 approved these changes

@jenshnielsen jenshnielsen jenshnielsen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
version 0.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@trevormorgan @codecov-commenter @jenshnielsen @astafan8 @Dominik-Vogel