Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to generate arbitrary waveform #779

Merged
merged 9 commits into from
Jan 30, 2024

Conversation

picarro-yren
Copy link
Contributor

@picarro-yren picarro-yren commented Jan 28, 2024

This PR adds an arb_func in PulseAtoms to allow users generating arbitrary waveforms.

PulseAtoms only contains ramp and sine functions, but in real experiments more complicated waveforms are needed. For example, generating a waveform that contains 2 sine waves with different frequencies.

A unit test is also added for testing this new feature

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7cf96c8) 82.30% compared to head (b4c951b) 82.33%.

Files Patch % Lines
broadbean/broadbean.py 63.63% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #779      +/-   ##
==========================================
+ Coverage   82.30%   82.33%   +0.03%     
==========================================
  Files          17       17              
  Lines        2441     2457      +16     
==========================================
+ Hits         2009     2023      +14     
- Misses        432      434       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@picarro-yren picarro-yren added this pull request to the merge queue Jan 30, 2024
Merged via the queue into QCoDeS:main with commit 9b54d32 Jan 30, 2024
10 checks passed
@picarro-yren picarro-yren deleted the yure/arb_function branch January 30, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants