Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format broadbean with ruff #811

Merged
merged 7 commits into from
Mar 6, 2024
Merged

Conversation

jenshnielsen
Copy link
Contributor

This replaces darker with the ruff formatter.
I think that by now formatting has become so established that it makes sense to format all our code automatically

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 62.62887% with 145 lines in your changes are missing coverage. Please review.

Project coverage is 71.88%. Comparing base (b3ba55d) to head (beb96a7).

Files Patch % Lines
src/broadbean/plotting.py 0.00% 75 Missing ⚠️
src/broadbean/sequence.py 76.47% 32 Missing ⚠️
src/broadbean/blueprint.py 78.31% 18 Missing ⚠️
src/broadbean/ripasso.py 57.14% 9 Missing ⚠️
src/broadbean/element.py 87.27% 7 Missing ⚠️
src/broadbean/tools.py 77.77% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
- Coverage   72.01%   71.88%   -0.13%     
==========================================
  Files           9        9              
  Lines        1547     1547              
==========================================
- Hits         1114     1112       -2     
- Misses        433      435       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jenshnielsen jenshnielsen added this pull request to the merge queue Mar 6, 2024
Merged via the queue into QCoDeS:main with commit 97caafa Mar 6, 2024
11 of 13 checks passed
@jenshnielsen jenshnielsen deleted the ruff_format branch March 6, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants