Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scipy version plus minor documentation updates #490

Merged
merged 1 commit into from
Jul 25, 2021

Conversation

qiyanjun
Copy link
Member

What does this PR do?

Summary

This is in response to #489

Additions

  • seems scipy==1.4.1 unnecessary

Changes

  • scipy>=1.4.1
  • two minor documentation updates adding how to install from master version via
git clone https://github.com/QData/TextAttack.git
cd TextAttack
pip install .[dev]

Checklist

  • [x ] The title of your pull request should be a summary of its contribution.
  • [x ] Please write detailed description of what parts have been newly added and what parts have been modified. Please also explain why certain changes were made.
  • [ x] If your pull request addresses an issue, please mention the issue number in the pull request description to make sure they are linked (and people consulting the issue know you are working on it)
  • [ ] To indicate a work in progress please mark it as a draft on Github.
  • [ ] Make sure existing tests pass.
  • [ ] Add relevant tests. No quality testing = no merge.
  • [ ] All public methods must have informative docstrings that work nicely with sphinx. For new modules/files, please add/modify the appropriate .rst file in TextAttack/docs/apidoc.'

@qiyanjun qiyanjun merged commit 1ff364a into master Jul 25, 2021
@qiyanjun qiyanjun deleted the scipy-version-plus-two-doc-updates branch July 26, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant