Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FixBug] Fix bug with loading pretrained lstm and cnn models #505

Merged
merged 2 commits into from
Aug 1, 2021

Conversation

jinyongyoo
Copy link
Collaborator

What does this PR do?

This fixes issue #485.

Summary

Update model paths of CNN and LSTM models defined in model_args.py to model_v2, which is a new path in S3 that contains the same model parameters and a new config.json file that specifies the model configurations.

Checklist

  • The title of your pull request should be a summary of its contribution.
  • Please write detailed description of what parts have been newly added and what parts have been modified. Please also explain why certain changes were made.
  • If your pull request addresses an issue, please mention the issue number in the pull request description to make sure they are linked (and people consulting the issue know you are working on it)
  • To indicate a work in progress please mark it as a draft on Github.
  • Make sure existing tests pass.
  • Add relevant tests. No quality testing = no merge.
  • All public methods must have informative docstrings that work nicely with sphinx. For new modules/files, please add/modify the appropriate .rst file in TextAttack/docs/apidoc.'

@qiyanjun qiyanjun merged commit c30728b into master Aug 1, 2021
@qiyanjun qiyanjun deleted the s3-model-fix branch August 2, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants