Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logger bug #544

Closed
wants to merge 3 commits into from
Closed

fix logger bug #544

wants to merge 3 commits into from

Conversation

qiyanjun
Copy link
Member

@qiyanjun qiyanjun commented Oct 14, 2021

What does this PR do?

Summary

Additions

Changes

Checklist

  • The title of your pull request should be a summary of its contribution.
  • [ ] Please write detailed description of what parts have been newly added and what parts have been modified. Please also explain why certain changes were made.
  • [ ] If your pull request addresses an issue, please mention the issue number in the pull request description to make sure they are linked (and people consulting the issue know you are working on it)
  • [ ] To indicate a work in progress please mark it as a draft on Github.
  • [ ] Make sure existing tests pass.
  • [ ] Add relevant tests. No quality testing = no merge.
  • [ ] All public methods must have informative docstrings that work nicely with sphinx. For new modules/files, please add/modify the appropriate .rst file in TextAttack/docs/apidoc.'

Sorry, something went wrong.

@qiyanjun qiyanjun changed the title fix logger bug and add test_trainer_logger.py fix logger bug Oct 15, 2021
@qiyanjun
Copy link
Member Author

@ankitgv0 please help!

@agv7
Copy link
Contributor

agv7 commented Oct 22, 2021

@ankitgv0 please help!

Fixed the problem in #551 and a similar problem in #552

@Hanyu-Liu-123
Copy link
Collaborator

The issue is solved in pull request #551 thanks to @ankitgv0. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants