Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "textattack[tensorflow]" option in all tutorials #559

Merged
merged 4 commits into from
Oct 31, 2021

Conversation

qiyanjun
Copy link
Member

What does this PR do?

Allows for users to run all tutorials on Google Colab without any issues or bugs that require them to manually resolve.

Summary

Many of the TextAttack tutorials are missing dependency installation commands that cause them to crash when run directly on Google Colab Notebooks. Simple modifications to multiple tutorials so that they are informed on proper installation to avoid such dependency issues.

Additions

  • Mostly "!pip install textattack[tensorflow]" commands to the tutorials that required it.

Checklist

  • [ x] The title of your pull request should be a summary of its contribution.
  • [x ] Please write detailed description of what parts have been newly added and what parts have been modified. Please also explain why certain changes were made.
  • [ ] If your pull request addresses an issue, please mention the issue number in the pull request description to make sure they are linked (and people consulting the issue know you are working on it)
  • [ ] To indicate a work in progress please mark it as a draft on Github.
  • [ ] Make sure existing tests pass.
  • [ ] Add relevant tests. No quality testing = no merge.
  • [ ] All public methods must have informative docstrings that work nicely with sphinx. For new modules/files, please add/modify the appropriate .rst file in TextAttack/docs/apidoc.'

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@qiyanjun qiyanjun merged commit c014fc1 into master Oct 31, 2021
@qiyanjun qiyanjun deleted the tutorial-dependency branch November 9, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant