Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API docstrings for back translation #563

Merged
merged 8 commits into from
Nov 5, 2021

Conversation

cogeid
Copy link
Contributor

@cogeid cogeid commented Nov 3, 2021

Added API docstrings for back translation.

Also provides a temporary fix to pytest caused by a known issue from tensorflow.
the issue can be seen here
huggingface/transformers#14265
huggingface/transformers#14266
to solve the issue tensorflow 2.5.0 is installed instead of 2.6.0

Also added test for back translation.

@qiyanjun
Copy link
Member

qiyanjun commented Nov 5, 2021

@cogeid why we need to change setup for a docstring update?

"tensorflow==2.5.0", "tensorflow-estimator==2.5.0",

@qiyanjun
Copy link
Member

qiyanjun commented Nov 5, 2021

@cogeid where is the pytest fix?

@cogeid
Copy link
Contributor Author

cogeid commented Nov 5, 2021

@cogeid where is the pytest fix?

huggingface/transformers#14265 (comment)

seen by the comment above, with tensorflow 2.6.0 pytest will fail during collections, this is why I changed tensorflow to 2.5.0

Without the change we would encounter the same error during pytest
Screen Shot 2021-11-05 at 11 05 44 AM

Here was the failed run: https://github.com/QData/TextAttack/runs/4097646732?check_suite_focus=true

@qiyanjun qiyanjun merged commit d009b60 into master Nov 5, 2021
@qiyanjun qiyanjun deleted the Add-Docstrings-to-Back-Translation branch November 9, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants