Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dataset_args to correctly set dataset_split #659

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

VijayKalmath
Copy link
Contributor

What does this PR do?

Summary

In PR #533 , the third element of dataset_args needed to be set to args.dataset_split , but due to minor error the second element was being set as args.dataset_split instead.

*This code change lead to bug described in Issue #599. *

Commit includes appropriate fix to update the third element correctly.

Additions

Changes

Change code from

   			   dataset_args = (
                       dataset_args[:1] + (args.dataset_split,) + dataset_args[2:]
                   )

to

				   dataset_args = (
                        dataset_args[:2] + (args.dataset_split,) + dataset_args[3:]
                    )

Deletions

Issues Addressed

Fixes #599

Checklist

  • The title of your pull request should be a summary of its contribution.
  • Please write detailed description of what parts have been newly added and what parts have been modified. Please also explain why certain changes were made.
  • If your pull request addresses an issue, please mention the issue number in the pull request description to make sure they are linked (and people consulting the issue know you are working on it)
  • To indicate a work in progress please mark it as a draft on Github.
  • Make sure existing tests pass.
  • Add relevant tests. No quality testing = no merge.
  • All public methods must have informative docstrings that work nicely with sphinx. For new modules/files, please add/modify the appropriate .rst file in TextAttack/docs/apidoc.'

In PR QData#533 , the third element of dataset_args needed to be set to args.dataset_split , but due to minor error the second element was being set as args.dataset_split instead.

This code lead to bug described in Issue QData#599. 

Commit includes appropriate fix to update the third element correctly.
@jxmorris12 jxmorris12 merged commit 6d85f29 into QData:master Jun 8, 2022
@VijayKalmath VijayKalmath deleted the patch-2 branch June 8, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken --dataset-split parameter in CLI
2 participants