Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQUAD schema to HuggingFaceDataset class #660

Conversation

VijayKalmath
Copy link
Contributor

What does this PR do?

Summary

HuggingFaceDataset class has a list of common schemas to find the input and output columns.
Current list of schemas does not have SQUAD schema leading to ValueError.

Commit adds SQUAD schema to common schemas list inget_datasets_dataset_columns.

Additions

  • Added traditionally used SQUAD schema to get_datasets_dataset_columns in HuggingFaceDataset.py.

Changes

Deletions

Issues Addressed

Fixes #597

Checklist

  • The title of your pull request should be a summary of its contribution.
  • Please write detailed description of what parts have been newly added and what parts have been modified. Please also explain why certain changes were made.
  • If your pull request addresses an issue, please mention the issue number in the pull request description to make sure they are linked (and people consulting the issue know you are working on it)
  • To indicate a work in progress please mark it as a draft on Github.
  • Make sure existing tests pass.
  • [ ] Add relevant tests. No quality testing = no merge.
  • [ ] All public methods must have informative docstrings that work nicely with sphinx. For new modules/files, please add/modify the appropriate .rst file in TextAttack/docs/apidoc.'

HuggingFaceDataset has a list of common schemas to find the input
and output columns.
Current list of schemas does not have SQUAD schema leading to
ValueError.

Commit adds SQUAD schema to common schemas list in
get_datasets_dataset_columns
@jxmorris12 jxmorris12 merged commit 9688456 into QData:master Jun 8, 2022
@VijayKalmath VijayKalmath deleted the Add-SquadSchema-toHuggingFaceDatasetClass branch June 8, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported dataset schema for SQuAD
2 participants