Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename BERT constraint to SBERT #763

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Rename BERT constraint to SBERT #763

merged 1 commit into from
Mar 5, 2024

Conversation

k-ivey
Copy link
Collaborator

@k-ivey k-ivey commented Dec 7, 2023

What does this PR do?

Summary

This PR adds renames the BERT constraint, which is a sentence-level constraint using BERT, to SBERT to better reflect its functionality.

Additions

  • Rename BERT constraint to SBERT.

Changes

  • N/A

Deletions

  • N/A

Checklist

  • [ X ] The title of your pull request should be a summary of its contribution.
  • [ X ] Please write detailed description of what parts have been newly added and what parts have been modified. Please also explain why certain changes were made.
  • [ ] If your pull request addresses an issue, please mention the issue number in the pull request description to make sure they are linked (and people consulting the issue know you are working on it)
  • [ ] To indicate a work in progress please mark it as a draft on Github.
  • [ X ] Make sure existing tests pass.
  • [ ] Add relevant tests. No quality testing = no merge.
  • [ X ] All public methods must have informative docstrings that work nicely with sphinx. For new modules/files, please add/modify the appropriate .rst file in TextAttack/docs/apidoc.'

@jxmorris12
Copy link
Collaborator

thanks this is a good change

@jxmorris12 jxmorris12 merged commit f98fbe6 into QData:master Mar 5, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants