Add ZSA functionality (upstream) #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulLaux
changed the title
PaulLaux
force-pushed
the
zsa_functionalities_upstream
branch
2 times, most recently
from
a4f764b
to
a68d519
Compare
ConstanceBeguier
force-pushed
the
zsa_functionalities_upstream
branch
from
fc5c820
to
101afa8
Compare
|
Force pushed after rebasing on the last version of main branch |
ConstanceBeguier
force-pushed
the
zsa_functionalities_upstream
branch
from
86ab039
to
77abf73
Compare
It is now possible to create a Point from a constant.
This functionality is required to evaluate the old nullifier.
- for non split_notes, nf_old = Extract_P([PRF^{nfOrchard}_{nk}(rho_old) + psi_nf) mod q_P] NullifierK + cm_old)
- for split notes, nf_old = Extract_P([PRF^{nfOrchard}_{nk}(rho_old) + psi_nf) mod q_P] NullifierK + cm_old + NullifierL)
Short range checks on 4 and 5 bits are now performed with only one lookup (instead of 2). To do that, we added a column `table_short_range_tag` in the lookup table. This new column `table_short_range_tag` contains the value - 4 for rows used in short range check on 4 bits - 5 for rows used in short range check on 5 bits - 0 for rows used in short range check on 10 bits Disable tests on i686 and code coverage in CI
It is now possible to perform a mux between two points or between two non-identity points.
`mux(choice, left, right)` will return `left` when `choice=0` and `right` when `choice=1`.
`choice` must be constrained to `{0, 1}` outside the gate.
It is no longer needed to expose `from_coordinates_unchecked`.
…oint (#22) To share ZEC and ZSA hash computations in Orchard circuit's note commitment evaluation, we need to compute a Sinsemille hash from a private input point.
ConstanceBeguier
force-pushed
the
zsa_functionalities_upstream
branch
from
e29b127
to
e35f363
Compare
|
Force pushed after rebasing on the last version of main branch (and removing "PR 805" |
ConstanceBeguier
force-pushed
the
zsa_functionalities_upstream
branch
from
63064b9
to
dbcffa2
Compare
ConstanceBeguier
force-pushed
the
zsa_functionalities_upstream
branch
from
b39ad75
to
5f436dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following modifications are required to support the ZSA circuit changes:
mul_sign. The implementation is based on theq_mul_fixed_shortgate.CommitDomain::new_with_personalizationto initialize theCommitDomainfrom two different personalizations. This is required to be able to use an identicalRfor ZEC and ZSA note commitments but a differentQ.HashDomainin aCommitDomainpublicly to enable the usage of Sinsemilla hash function from aCommitDomain.commit_from_hash_pointto evaluate a Sinsemilla commit from a hash point.hashandblindindependently.MUX(choice, left, right) = if {choice} right else leftPoint::new_from_constantto create a Point from a constant.hash_to_point_with_private_initto evaluate a Sinsemilla hash from a private initial point (instead of a public initial point)