warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:850:10 | 850 | .fold(Some(ValueSum::zero()), |acc, action| { | __________^ 851 | | acc? + action.value_sum() 852 | | }) | |__________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `#[warn(clippy::manual_try_fold)]` on by default

warning: the following explicit lifetimes could be elided: 'a --> src/bundle.rs:221:14 | 221 | impl<'a, A: fmt::Debug, D: OrchardDomainCommon> fmt::Debug for Actions<'a, A, D> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 221 - impl<'a, A: fmt::Debug, D: OrchardDomainCommon> fmt::Debug for Actions<'a, A, D> { 221 + impl<A: fmt::Debug, D: OrchardDomainCommon> fmt::Debug for Actions<'_, A, D> { |

warning: large array defined as const --> src/constants/fixed_bases/commit_ivk_r.rs:30:1 | 30 | pub const U: [[[u8; 32]; super::H]; super::NUM_WINDOWS] = [ | ^ ----- help: make this a static item: `static` | _| | | 31 | | [ 32 | | [ 33 | | 38, 43, 235, 53, 200, 116, 153, 194, 47, 92, 18, 54, 194, 221, 170, 155, 205, 143, 92, ... | 2920 | | ], 2921 | | ]; | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays = note: `#[warn(clippy::large_const_arrays)]` on by default

warning: large array defined as const --> src/constants/fixed_bases/note_commit_r.rs:30:1 | 30 | pub const U: [[[u8; 32]; super::H]; super::NUM_WINDOWS] = [ | ^ ----- help: make this a static item: `static` | _| | | 31 | | [ 32 | | [ 33 | | 114, 245, 9, 0, 5, 43, 7, 118, 244, 43, 15, 200, 116, 210, 0, 24, 161, 28, 185, 152, ... | 2920 | | ], 2921 | | ]; | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays

warning: large array defined as const --> src/constants/fixed_bases/nullifier_k.rs:30:1 | 30 | pub const U: [[[u8; 32]; super::H]; super::NUM_WINDOWS] = [ | ^ ----- help: make this a static item: `static` | _| | | 31 | | [ 32 | | [ 33 | | 8, 177, 117, 90, 104, 127, 169, 131, 254, 128, 23, 151, 181, 247, 22, 208, 55, 1, 147, ... | 2920 | | ], 2921 | | ]; | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays

warning: large array defined as const --> src/constants/fixed_bases/spend_auth_g.rs:30:1 | 30 | pub const U: [[[u8; 32]; super::H]; super::NUM_WINDOWS] = [ | ^ ----- help: make this a static item: `static` | _| | | 31 | | [ 32 | | [ 33 | | 134, 139, 159, 167, 179, 203, 183, 86, 54, 69, 108, 127, 183, 40, 226, 188, 34, 72, ... | 2920 | | ], 2921 | | ]; | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays

warning: large array defined as const --> src/constants/fixed_bases/value_commit_r.rs:31:1 | 31 | pub const U: [[[u8; 32]; super::H]; super::NUM_WINDOWS] = [ | ^ ----- help: make this a static item: `static` | _| | | 32 | | [ 33 | | [ 34 | | 139, 239, 3, 113, 200, 111, 72, 118, 105, 23, 186, 243, 234, 10, 173, 186, 53, 143, ... | 2921 | | ], 2922 | | ]; | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays

warning: doc list item without indentation --> src/domain/orchard_domain.rs:78:9 | 78 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244] | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 78 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244] | ++

warning: use of a fallible conversion when an infallible one could be used --> src/keys.rs:270:27 | 270 | self.0.to_bytes().try_into().unwrap() | ^^^^^^^^^^^^^^^^^^^ | = note: converting `GenericArray<u8, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default help: use | 270 - self.0.to_bytes().try_into().unwrap() 270 + self.0.to_bytes().into() |