forked from zcash/orchard
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cargo clippy warnings in PR #138 #139
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a finalization set, fix tests accordingly
… update verify_issue_bundle function to ensure the first asset issuance contains the reference note, update tests and docs accordingly
… verification only, update IssueAction::verify and return (AssetBase, NoteValue) from it instead of (AssetBase, AssetInfo<...>)
…ication test functions updated to check the result of the verify_issue_bundle directly
…ssetBase error according to #138 PR review comments
…al_state test) a function instead of closure according to #138 PR review comment
…ssueAction::verify, according to #138 PR review comment
…t as a return value of setup_params instead of a tuple
…refactor it according the #138 review comments
…s issuance_global_state.rs, and use copies of setup_params and TestParams there. The code doesn't compile because some methods need to be public. Further fixes are required.
…b(crate) method to generate random keys
PR Summary
|
Closed in favour of #140. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a couple of cargo clippy warnings in PR #138.