Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo clippy warnings in PR #138 #139

Closed
wants to merge 32 commits into from
Closed

Fix cargo clippy warnings in PR #138 #139

wants to merge 32 commits into from

Conversation

dmidem
Copy link

@dmidem dmidem commented Feb 4, 2025

This PR addresses a couple of cargo clippy warnings in PR #138.

dmidem added 30 commits January 21, 2025 13:00
… update verify_issue_bundle function to ensure the first asset issuance contains the reference note, update tests and docs accordingly
… verification only, update IssueAction::verify and return (AssetBase, NoteValue) from it instead of (AssetBase, AssetInfo<...>)
…ication test functions updated to check the result of the verify_issue_bundle directly
…ssetBase error according to #138 PR review comments
…al_state test) a function instead of closure according to #138 PR review comment
…ssueAction::verify, according to #138 PR review comment
…t as a return value of setup_params instead of a tuple
…s issuance_global_state.rs, and use copies of setup_params and TestParams there. The code doesn't compile because some methods need to be public. Further fixes are required.
Copy link

what-the-diff bot commented Feb 4, 2025

PR Summary

  • Introduction of a new asset_record module

    • A new structural model representation for collective asset data, named AssetRecord, has been introduced. This includes characteristics such as the amount of the asset, its completion status, and a reference note.
    • This module also includes ways to create AssetRecord.
  • Removal of supply_info module

    • The former module supply_info and its functions has been removed completely.
  • Updates to lib.rs

    • This update implements the previously added asset_record module and removes the now irrelevant supply_info module.
  • Tests added to issuance_global_state.rs

    • To ensure the issuance process workflow is correct, tests have been added. This is to specifically validate the bundling process in terms of global state, both with and without error.
  • Changes to assertions in zsa.rs

    • Verification calls in the issue_zsa_notes function now employ a closure that yields None replacing a HashSet.

@dmidem
Copy link
Author

dmidem commented Feb 4, 2025

Closed in favour of #140.

@dmidem dmidem closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant