Updates to txid_digest
#15
Conversation
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
zip-0226.rst
Outdated
| txid_digest | ||
| ├── header_digest | ||
| ├── transparent_digest | ||
| │ ├── prevouts_digest | ||
| │ ├── sequence_digest | ||
| │ └── outputs_digest | ||
| ├── sapling_digest | ||
| │ ├── sapling_spends_digest | ||
| │ │ ├── sapling_spends_compact_digest | ||
| │ │ └── sapling_spends_noncompact_digest | ||
| │ ├── sapling_outputs_digest | ||
| │ │ ├── sapling_outputs_compact_digest | ||
| │ │ ├── sapling_outputs_memos_digest | ||
| │ │ └── sapling_outputs_noncompact_digest | ||
| │ └── valueBalance | ||
| └── orchard_digest | ||
| │ ├── orchard_actions_compact_digest | ||
| │ ├── orchard_actions_assetid_digest | ||
| │ ├── orchard_actions_memos_digest | ||
| │ ├── orchard_actions_noncompact_digest | ||
| │ ├── flagsOrchard | ||
| │ ├── valueBalanceOrchard | ||
| │ └── anchorOrchard | ||
| └── issuance_digest |
There was a problem hiding this comment.
Let's do just top level here:
txid_digest
├── header_digest
├── transparent_digest
├── sapling_digest
└── orchard_digest
└── issuance_digest
There was a problem hiding this comment.
Actually let's remove the big tree completely. Seems redundant.
There was a problem hiding this comment.
I updated the tree, with the [UPDATED FOR ZSA] labels. Thought it seemed good for completeness to have the whole table mentioned once.
Maybe we could remove the issuance version of the tree from the Issuance ZIP (ZIP 227), since that is repeated information from the Transfer ZIP (ZIP 226).
There was a problem hiding this comment.
It does looks good but we can't have this duplication, it will bite us if we will keep it.
zip-0226.rst
Outdated
| =========== | ||
|
|
||
| The transaction digest algorithm defined in ZIP 244 [#zip-0244]_ is modified by the ZSA protocol to add a new branch for issuance information, and add an additional hash for the Asset Base within the ``orchard_digest``. The details of these changes are described in this section. The overall tree structure of the hash is as follows, and the additional names not referenced in ZIP 244 are described in detail below:: | ||
|
|
There was a problem hiding this comment.
Changes and additions to the Orchard protocol are styled in Bold.
There was a problem hiding this comment.
As discussed, now using [UPDATED FOR ZSA] to highlight this.
There was a problem hiding this comment.
Great.
Still, we don't need the big tree, it's a duplication over all the other information. Let's remove it.
zip-0226.rst
Outdated
| T.4b: orchard_actions_assetid_digest | ||
| '''''''''''''''''''''''''''''''''''' | ||
|
|
||
| A BLAKE2b-256 hash of the subset of Zcash Shielded Asset identifier data for all Orchard Actions belonging to the transaction. For each Action, the following elements are included in the hash:: | ||
|
|
||
| T.4b.i: assetid (field encoding bytes) | ||
|
|
||
| The personalization field of this hash is set to:: | ||
|
|
||
| "ZTxIdOrcActAHash" |
There was a problem hiding this comment.
Think we need to remove it as described above.
zip-0226.rst
Outdated
| =========== | ||
|
|
||
| The transaction digest algorithm defined in ZIP 244 [#zip-0244]_ is modified by the ZSA protocol to add a new branch for issuance information, and add an additional hash for the Asset Base within the ``orchard_digest``. The details of these changes are described in this section. The overall tree structure of the hash is as follows, and the additional names not referenced in ZIP 244 are described in detail below:: | ||
|
|
There was a problem hiding this comment.
Great.
Still, we don't need the big tree, it's a duplication over all the other information. Let's remove it.
zip-0226.rst
Outdated
| txid_digest | ||
| ├── header_digest | ||
| ├── transparent_digest | ||
| │ ├── prevouts_digest | ||
| │ ├── sequence_digest | ||
| │ └── outputs_digest | ||
| ├── sapling_digest | ||
| │ ├── sapling_spends_digest | ||
| │ │ ├── sapling_spends_compact_digest | ||
| │ │ └── sapling_spends_noncompact_digest | ||
| │ ├── sapling_outputs_digest | ||
| │ │ ├── sapling_outputs_compact_digest | ||
| │ │ ├── sapling_outputs_memos_digest | ||
| │ │ └── sapling_outputs_noncompact_digest | ||
| │ └── valueBalance | ||
| └── orchard_digest | ||
| │ ├── orchard_actions_compact_digest | ||
| │ ├── orchard_actions_assetid_digest | ||
| │ ├── orchard_actions_memos_digest | ||
| │ ├── orchard_actions_noncompact_digest | ||
| │ ├── flagsOrchard | ||
| │ ├── valueBalanceOrchard | ||
| │ └── anchorOrchard | ||
| └── issuance_digest |
There was a problem hiding this comment.
It does looks good but we can't have this duplication, it will bite us if we will keep it.
This details the changes to the transaction digest algorithm for the ZSA protocol. - A new branch is added for hashing the information in a transaction related to issuance. - Some branches are added and modified in the orchard_digest subtree to account for the additional Asset Base value that needs to be hashed.
This details the changes to the transaction digest algorithm for the ZSA protocol. - A new branch is added for hashing the information in a transaction related to issuance. - Some branches are added and modified in the orchard_digest subtree to account for the additional Asset Base value that needs to be hashed.
This PR details the changes to the transaction digest algorithm for the ZSA protocol.